cshannon commented on code in PR #4317:
URL: https://github.com/apache/accumulo/pull/4317#discussion_r1509984426
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/split/FindSplits.java:
##########
@@ -75,13 +88,17 @@ public Repo<Manager> call(FateId fateId, Manager manager)
throws Exception {
if (splits.isEmpty()) {
log.info("Tablet {} needs to split, but no split points could be found.",
tabletMetadata.getExtent());
- // ELASTICITY_TODO record the fact that tablet is un-splittable in
metadata table in a new
- // column. Record the config used to reach this decision and a hash of
the file. The tablet
- // mgmt iterator can inspect this column and only try to split the
tablet when something has
- // changed.
+
+ // TODO: Do we care about conditional mutations here? I don't think it
is required because
Review Comment:
Latest update adds in a conditional mutation, i added the condition to
require files be the same as i figure we should fail fast and retry vs having
to submit another op later when it detects it's different, i added a comment
about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
