ddanielr commented on PR #4338: URL: https://github.com/apache/accumulo/pull/4338#issuecomment-1979542399
> > I removed this code with my changes in #4273 since the config is no longer across multiple properties. But would it make sense to add some sort of on-demand SPI validation utility? https://github.com/apache/accumulo/blob/2.1/server/base/src/main/java/org/apache/accumulo/server/conf/CheckCompactionConfig.java > > The CompactionPlanner is an SPI, so DefaultCompactionPlanner could implement the validation interface and it would be validated on startup. Right, I understand that from these changes. I think that's a great benefit. I was trying to point out that the current compaction SPI validation utility uses a specific file path which allows for validation of proposed property changes without modifying ZK state. https://github.com/apache/accumulo/blob/d91d0162115ae66112a104278bcd14e8085936d3/server/base/src/main/java/org/apache/accumulo/server/conf/CheckCompactionConfig.java#L96 So instead dealing with multiple failed startups, a user could have faster feedback by populating a config file with the proposed property set and then running `./accumulo spi-validate <path to prop file>`. This allows the user to test a SPI related change without impacting the system. With the current changes in #4338 , `CheckCompactionConfig` could be removed in 2.1 in favor of a generic `prop validation` or `spi-validation` command which just runs the same validation code as ServerContext. I also looked at `CheckServerConfig` but that doesn't take in a filepath as an option. https://github.com/apache/accumulo/blob/d91d0162115ae66112a104278bcd14e8085936d3/server/base/src/main/java/org/apache/accumulo/server/conf/CheckServerConfig.java#L30-L34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
