cshannon commented on code in PR #4317: URL: https://github.com/apache/accumulo/pull/4317#discussion_r1517700241
########## core/src/test/java/org/apache/accumulo/core/metadata/schema/TabletMetadataTest.java: ########## @@ -339,7 +344,47 @@ public void testCompactionRequestedColumn() { } @Test - public void testUnkownColFamily() { + public void testUnsplittableColumn() { + KeyExtent extent = new KeyExtent(TableId.of("5"), new Text("df"), new Text("da")); + + StoredTabletFile sf1 = StoredTabletFile.of(new Path("hdfs://nn1/acc/tables/1/t-0001/sf1.rf")); + StoredTabletFile sf2 = StoredTabletFile.of(new Path("hdfs://nn1/acc/tables/1/t-0001/sf2.rf")); + StoredTabletFile sf3 = StoredTabletFile.of(new Path("hdfs://nn1/acc/tables/1/t-0001/sf3.rf")); + var unsplittableMeta = + UnSplittableMetadata.toUnSplittable(100, 110, 120, Set.of(sf1, sf2, sf3)); + + // Test with files + Mutation mutation = TabletColumnFamily.createPrevRowMutation(extent); + SplitColumnFamily.UNSPLITTABLE_COLUMN.put(mutation, new Value(unsplittableMeta.toJson())); + TabletMetadata tm = TabletMetadata.convertRow(toRowMap(mutation).entrySet().iterator(), + EnumSet.of(UNSPLITTABLE), true, false); + assertEquals(unsplittableMeta, tm.getUnSplittable()); Review Comment: Test was updated in 6c3358b5783b19ec6d73c7f7a121d0b0493c4333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org