cshannon commented on code in PR #4453:
URL: https://github.com/apache/accumulo/pull/4453#discussion_r1562654000
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/scan/LookupTask.java:
##########
@@ -76,6 +77,11 @@ public void run() {
TableConfiguration acuTableConf =
server.getTableConfiguration(session.threadPoolExtent);
long maxResultsSize =
acuTableConf.getAsBytes(Property.TABLE_SCAN_MAXMEM);
+ // Always return large root tablets
+ if
(session.threadPoolExtent.tableId().equals(AccumuloTable.ROOT.tableId())) {
+ maxResultsSize = Long.MAX_VALUE;
Review Comment:
I agree that going smaller than Long.MAX_VALUE makes sense.
Maybe the best thing is to just take the maximum value between the default
and the user setting so we always use at least the default size but allow users
to go higher.
```java
maxResultsSize = Math.max(maxResultsSize, ConfigurationTypeHelper
getFixedMemoryAsBytes(Property.TABLE_SCAN_MAXMEM.getDefaultValue()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
