dlmarion commented on code in PR #4464:
URL: https://github.com/apache/accumulo/pull/4464#discussion_r1568696640
##########
server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java:
##########
@@ -297,6 +309,25 @@ public void run() {
gcCycleMetrics.incrementRunCycleCount();
long gcDelay =
getConfiguration().getTimeInMillis(Property.GC_CYCLE_DELAY);
+
+ if (NanoTime.now().subtract(lastCompactorCheck).toMillis() > gcDelay *
3) {
+ Map<String,Set<TableId>> resourceMapping = new HashMap<>();
+ for (TableId tid : AccumuloTable.allTableIds()) {
+ TableConfiguration tconf = getContext().getTableConfiguration(tid);
+ String resourceGroup =
tconf.get(TableLoadBalancer.TABLE_ASSIGNMENT_GROUP_PROPERTY);
+ resourceGroup =
+ resourceGroup == null ? Constants.DEFAULT_RESOURCE_GROUP_NAME
: resourceGroup;
+ resourceMapping.getOrDefault(resourceGroup, new
HashSet<>()).add(tid);
+ }
+ for (Entry<String,Set<TableId>> e : resourceMapping.entrySet()) {
+ if (ExternalCompactionUtil.countCompactors(e.getKey(),
getContext()) == 0) {
+ log.warn("No Compactors exist in resource group {} for system
table {}", e.getKey(),
Review Comment:
@EdColeman - what's your thought on a more serious looking message?
```suggestion
log.error("System misconfiguration - There are no Compactors
running in resource group {} for system tables: {}", e.getKey(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
