EdColeman commented on PR #4473: URL: https://github.com/apache/accumulo/pull/4473#issuecomment-2066397194
The changes LGTM, but I was wondering if the logging for nothing selected for a user compaction should be debug. Would it be "normal" for a user-initiated compaction to have no work? I guess if there was no data in a tablet and the file size was 0? My impression is that a user compaction should always result in tablets being processed, filtered and the results written into a new file. Even if it was a single tablet file from a previous compaction (starts with the 'A` prefix), that file is processed and a new `A` file is generated. If my above assumption is correct, then would it not be unexpected that a user-initiated compaction yielded no work and logging at something higher than trace would be appropriate? If I ran a compaction and then noticed that some or all of the files did not get updated with new timestamps I would be suspecting a bug and being able to see that the planner selected no work may help point to the issue? At trace, it may take longer to zero in on an issue? (This comment actually is not objecting to the trace level as much as just trying to understand the conditions that would lead to no work.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
