DomGarguilo commented on code in PR #4494:
URL: https://github.com/apache/accumulo/pull/4494#discussion_r1581224445


##########
server/manager/src/main/java/org/apache/accumulo/manager/ManagerTime.java:
##########
@@ -58,8 +62,7 @@ public ManagerTime(Manager manager, AccumuloConfiguration 
conf) throws IOExcepti
 
     try {
       zk.putPersistentData(zPath, "0".getBytes(UTF_8), NodeExistsPolicy.SKIP);
-      skewAmount =
-          new AtomicLong(Long.parseLong(new String(zk.getData(zPath), UTF_8)) 
- System.nanoTime());
+      skewAmount = new AtomicLong(updatedSkew(zk.getData(zPath)));

Review Comment:
   Would skewAmount be a good candidate for conversion to 
[NanoTime](https://github.com/apache/accumulo/blob/main/core/src/main/java/org/apache/accumulo/core/util/time/NanoTime.java)?
 Not sure if it would be in the scope of this PR but thought I would point it 
out.
   
   Maybe the `time` member variable in `SteadyTime` too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to