EdColeman commented on code in PR #4497:
URL: https://github.com/apache/accumulo/pull/4497#discussion_r1581527944
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -344,12 +344,18 @@ public void run() {
TServerConnection client =
manager.tserverSet.getConnection(location.getServerInstance());
if (client != null) {
- Manager.log.trace("[{}] Requesting TabletServer {} unload {}
{}", store.name(),
- location.getServerInstance(), tls.extent,
goal.howUnload());
- client.unloadTablet(manager.managerLock, tls.extent,
goal.howUnload(),
- manager.getSteadyTime());
- unloaded++;
- totalUnloaded++;
+ try {
+ Manager.log.trace("[{}] Requesting TabletServer {} unload
{} {}", store.name(),
+ location.getServerInstance(), tls.extent,
goal.howUnload());
+ client.unloadTablet(manager.managerLock, tls.extent,
goal.howUnload(),
+ manager.getSteadyTime());
+ unloaded++;
+ totalUnloaded++;
+ } catch (TException tException) {
+ Manager.log.warn("[{}] Failed to request tablet unload {}
{} {} {}",
Review Comment:
Is this is going to be in a loop and / or retried? Wondering if logging at a
lower level may be appropriate. Particularity if the RPC could be transient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
