keith-turner commented on code in PR #4461:
URL: https://github.com/apache/accumulo/pull/4461#discussion_r1585669524
##########
core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java:
##########
@@ -367,6 +367,28 @@
* <td>Gauge</td>
* <td></td>
* </tr>
+ * <!-- scan server -->
+ * <tr>
+ * <th>N/A</th>
+ * <th>N/A</th>
+ * <th>{@value #METRICS_SSERVER_REGISTRATION_TIMER}</th>
Review Comment:
There is a mismatch between this code and this name. The ScanServer code
uses the terminology of reserving files. The metric names should probably
reflect that and use reservation in their names instead of registration.
```suggestion
* <th>{@value #METRICS_SSERVER_RESERVATION_TIMER}</th>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
