cshannon commented on code in PR #4494:
URL: https://github.com/apache/accumulo/pull/4494#discussion_r1596695368
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -1386,7 +1386,7 @@ private void handleDeadTablets(TabletLists tLists,
WalStateManager wals)
deadTablets.subList(0, maxServersToShow));
Manager.log.debug("logs for dead servers: {}", deadLogs);
if (canSuspendTablets()) {
- store.suspend(deadTablets, deadLogs, manager.getSteadyTime());
+ store.suspend(deadTablets, deadLogs,
manager.getSteadyTime().getMillis());
Review Comment:
I started working on this and made the changes and it looks like there will
be a decent number. Here is the work in progress commit:
https://github.com/apache/accumulo/commit/a4bc8f55dac0644de15b9f80db67dec8a9e370f7
I think it should be a follow on because it touches a lot of files and may
introduce more merge conflicts when merging from 3.1 to elasticity so probably
best to isolate it. I can open a follow on PR with that branch and change once
this is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
