keith-turner commented on PR #4552: URL: https://github.com/apache/accumulo/pull/4552#issuecomment-2106000925
The motivation behind this is that in the past the scan servers tablet metadata cache was instrumented w/ micrometere but not recording stats. Was attempting to use the cache metrics and they were zero and/or non existent. Spent a long time tracking down why instrumentation was not working (was looking at micrometer source code first thinking there was a bug there). So this change is an attempt to catch future changes where the cache is changed to no longer record stats. Tried to think of a more general way to catch this mismatch between cache builder and cahce insturmention that could catch the problem anywhere in the Accumulo code base, but could not think of anything. So this change adds a check to the place where I saw it and it caused me problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
