cshannon commented on code in PR #4551:
URL: https://github.com/apache/accumulo/pull/4551#discussion_r1597694921


##########
test/src/main/java/org/apache/accumulo/test/ScanServerConcurrentTabletScanIT.java:
##########
@@ -135,7 +157,15 @@ public void 
testScanSameTabletDifferentDataTabletMetadataCacheEnabled() throws E
       // Ingest another 100 k/v with a different column family
       final int secondBatchOfEntriesCount = ingest(client, tableName, 10, 10, 
0, "COLB", true);
 
+      // Add a sleep that is long enough that the configured refresh interval 
passes if
+      // the test has been set to use one.
+      Thread.sleep(1000);

Review Comment:
   Thanks for the tip for using the mock time, I don't think it would be easy 
to set in this case but would be useful for other cases for sure. We also have 
a [Wait.waitFor() 
](https://github.com/apache/accumulo/blob/861d28b64ba80b82300306df148ea3f969e99e6d/test/src/main/java/org/apache/accumulo/test/util/Wait.java#L87)
 utility which could be used here instead of sleep by scanning in a loop 
probably, at least to check for the refresh case (wouldn't help so much for 
checking it didn't refresh)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to