dlmarion commented on code in PR #4555:
URL: https://github.com/apache/accumulo/pull/4555#discussion_r1598970710
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/metrics/TabletServerUpdateMetrics.java:
##########
@@ -68,10 +69,14 @@ public void addMutationArraySize(long value) {
@Override
public void registerMetrics(MeterRegistry registry) {
- permissionErrorsCounter = registry.counter(METRICS_UPDATE_ERRORS, "type",
"permission");
- unknownTabletErrorsCounter = registry.counter(METRICS_UPDATE_ERRORS,
"type", "unknown.tablet");
- constraintViolationsCounter =
- registry.counter(METRICS_UPDATE_ERRORS, "type",
"constraint.violation");
+ FunctionCounter.builder("tabletServerUpdateErrors", permissionErrorsCount,
AtomicLong::get)
Review Comment:
I think the names still need to be in the standard form,
`accumulo.tserver.updates.errors.permission` for example. Do these need to be
unique, is that why you are not using `METRICS_UPDATE_ERRORS` for these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
