dlmarion commented on code in PR #4568:
URL: https://github.com/apache/accumulo/pull/4568#discussion_r1605029978
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java:
##########
@@ -156,8 +156,13 @@ private TabletMetadata(Builder tmBuilder) {
this.compacted = tmBuilder.compacted.build();
this.userCompactionsRequested = tmBuilder.userCompactionsRequested.build();
this.unSplittableMetadata = tmBuilder.unSplittableMetadata;
- this.fileSize =
- Suppliers.memoize(() ->
files.values().stream().mapToLong(DataFileValue::getSize).sum());
+ this.fileSize = Suppliers.memoize(() -> {
Review Comment:
`files.values().stream().mapToLong(DataFileValue::getSize).sum()` has the
following call stack:
*
[values](https://github.com/openjdk/jdk/blob/jdk-11%2B28/src/java.base/share/classes/java/util/AbstractMap.java#L405)
(creates new AbstractCollection)
*
[stream](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/Collection.java#L747)
(calls spliterator and then StreamSupport.stream)
*
[spliterator](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/Collection.java#L728)
(calls Spliterators.spliterator)
*
[Spliterators.spliterator](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/Spliterators.java#L140)
(creates new ArraySpliterator)
*
[StreamSupport.stream](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/stream/StreamSupport.java#L67)
(returns a new ReferencePipeline.Head object)
*
[mapToLong](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/stream/ReferencePipeline.java#L240)
( creates a new LongPipeline.StatelessOp object)
*
[sum](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/stream/LongPipeline.java#L458)
(calls reduce())
*
[reduce](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/stream/LongPipeline.java#L501
(calls ReduceOps.makeLong and then evaluate)
*
[ReduceOps.makeLong](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/stream/ReduceOps.java#L462)
(creates a new ReduceOp and returns it)
*
[evaluate](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/stream/AbstractPipeline.java#L257)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
