cshannon commented on code in PR #4480:
URL: https://github.com/apache/accumulo/pull/4480#discussion_r1605430255
##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java:
##########
@@ -458,7 +458,8 @@ public static boolean canReserveCompaction(TabletMetadata
tablet, CompactionKind
tablet.getExtent(), userRequestedCompactions);
return false;
} else if (tablet.getSelectedFiles() != null
- && !Collections.disjoint(jobFiles,
tablet.getSelectedFiles().getFiles())) {
+ && (tablet.getSelectedFiles().getCompletedJobs() > 0
Review Comment:
This has been implemented in the latest commit, dafdc87afc but I just wanted
to note that the logic above is backwards. Time time check should be:
```java
if(steadyTime.minus(tabletMetadata.getSelectedFiles().getSelectedTime()).toMillis()
< selectedExpirationDuration) {
return tabletMetadata.getSelectedFiles().getFiles();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
