keith-turner commented on PR #4577: URL: https://github.com/apache/accumulo/pull/4577#issuecomment-2121468480
@DomGarguilo sorry my writeup was awful for #4509. For the write time was looking to track how long it takes to call ` getContext().getAmple().putScanServerFileReferences(refs);` [here](https://github.com/apache/accumulo/blob/dd61442925f9236fda1bc176394052c30547156f/server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java#L604). This is the time it take write out scan server refs to the metadata table. For collisions, my terminology was really bad. The event I wanted to track was the case where tablets files changed during the process of attempting to reserve files. That could be done by incrementing a metric immediately before returning null [here](https://github.com/apache/accumulo/blob/dd61442925f9236fda1bc176394052c30547156f/server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java#L638). The [log message](https://github.com/apache/accumulo/blob/dd61442925f9236fda1bc176394052c30547156f/server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java#L635) a few lines up describes what is happening. Not sure colliosn is the best single word for the metric name that describes `tablet files changed while attempting to reference files`, but can not think of something more succinct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
