EdColeman commented on code in PR #4567: URL: https://github.com/apache/accumulo/pull/4567#discussion_r1609056212
########## server/base/src/main/java/org/apache/accumulo/server/util/serviceStatus/ServiceStatusReport.java: ########## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.server.util.serviceStatus; + +import java.time.ZoneId; +import java.time.ZonedDateTime; +import java.time.format.DateTimeFormatter; +import java.util.Map; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.google.gson.Gson; + +/** + * Wrapper for JSON formatted report. + */ +public class ServiceStatusReport { + + private static final Logger LOG = LoggerFactory.getLogger(ServiceStatusReport.class); + + private static final Gson gson = new Gson(); + + private static final DateTimeFormatter rptTimeFmt = + DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'"); + private static final String I2 = " "; + private static final String I4 = " "; + + private final String reportTime; + private final int zkReadErrors; + private final boolean noHosts; + private final Map<ReportKey,StatusSummary> summaryMap; + + public ServiceStatusReport(final Map<ReportKey,StatusSummary> summaryMap, final boolean noHosts) { + reportTime = rptTimeFmt.format(ZonedDateTime.now(ZoneId.of("UTC"))); + zkReadErrors = summaryMap.values().stream().map(StatusSummary::getErrorCount) + .reduce(Integer::sum).orElse(0); + this.noHosts = noHosts; + this.summaryMap = summaryMap; + } + + public String getReportTime() { + return reportTime; + } + + public Map<ReportKey,StatusSummary> getSummaryMap() { + return summaryMap; + } + + public String toJson() { + return gson.toJson(this, ServiceStatusReport.class); + } + + public String report(final StringBuilder sb) { + sb.append("Report time: ").append(rptTimeFmt.format(ZonedDateTime.now(ZoneId.of("UTC")))) + .append("\n"); + int zkErrors = summaryMap.values().stream().map(StatusSummary::getErrorCount) + .reduce(Integer::sum).orElse(0); + sb.append("ZooKeeper read errors: ").append(zkErrors).append("\n"); + + writeServiceStatus(sb, ReportKey.MANAGER, summaryMap.get(ReportKey.MANAGER), noHosts); + writeServiceStatus(sb, ReportKey.MONITOR, summaryMap.get(ReportKey.MONITOR), noHosts); + writeServiceStatus(sb, ReportKey.GC, summaryMap.get(ReportKey.GC), noHosts); + writeServiceStatus(sb, ReportKey.T_SERVER, summaryMap.get(ReportKey.T_SERVER), noHosts); + writeResourceGroups(sb, ReportKey.S_SERVER, summaryMap.get(ReportKey.S_SERVER), noHosts); + writeServiceStatus(sb, ReportKey.COORDINATOR, summaryMap.get(ReportKey.COORDINATOR), noHosts); + writeResourceGroups(sb, ReportKey.COMPACTOR, summaryMap.get(ReportKey.COMPACTOR), noHosts); + + sb.append("\n"); + LOG.trace("fmtStatus - with hosts: {}", summaryMap); + return sb.toString(); + } + + public void writeServiceStatus(final StringBuilder sb, final ReportKey displayNames, + final StatusSummary summary, boolean noHosts) { + if (summary == null) { + sb.append(displayNames).append(": unavailable").append("\n"); + return; + } + + writeCounts(sb, summary); + + // skip host info if requested + if (noHosts) { + return; + } + if (summary.getServiceCount() > 0) { + var hosts = summary.getServiceNames(); + hosts.forEach(h -> sb.append(I2).append(h).append("\n")); + } + } + + private void writeCounts(StringBuilder sb, StatusSummary summary) { + sb.append(summary.getDisplayName()).append(": count: ").append(summary.getServiceCount()); + if (summary.getErrorCount() > 0) { + sb.append(", (ZooKeeper errors: ").append(summary.getErrorCount()).append(")\n"); + } else { + sb.append("\n"); + } + } + + private void writeResourceGroups(final StringBuilder sb, final ReportKey reportKey, + final StatusSummary summary, boolean noHosts) { + if (summary == null) { + sb.append(reportKey).append(": unavailable").append("\n"); + return; + } + + writeCounts(sb, summary); + + // skip host info if requested + if (noHosts) { + return; + } + if (!summary.getResourceGroups().isEmpty()) { + sb.append(I2).append("resource groups:\n"); + summary.getResourceGroups().forEach(g -> sb.append(I4).append(g).append("\n")); Review Comment: Address in f5f92218bd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
