keith-turner commented on issue #4599:
URL: https://github.com/apache/accumulo/issues/4599#issuecomment-2129582096
> We don't necessarily have to implement something to provide some base
functionality. A user can extend one of our existing implementations or create
their own to provide this functionality.
Wondering if it would be useful to provide some kind of help in the SPI for
building micrometer filters related to Accumulo metrics. One possible way to do
this would be to have constants related to metrics in the SPI. This could
enable writing a MeterRegistryFactory that manipulates Accumulo metrics using
those constants. Could have something like the following.
```java
package org.apache.accumulo.core.spi.metrics;
class MetricsConstants {
static class Tags {
String INSTANCE_TAG = "instance.name";
}
static class Meters {
String COMPACTIONS_QUEUED = "...";
}
}
```
With the above then could have a scenario like the following.
* Custom MeterRegistryFactory is written against 3.1 that drops the
instance name tag. Its impl uses the `INSTANCE_TAG` constant from the SPI.
* Accumulo 4.0 makes a major changes to the instance name tag that user
need to consider. This change deletes INSTANCE_TAG constant from the SPI.
* The custom MeterRegistryFactory written against 3.1 no longer compiles
against 4.0 forcing an investigation of the change.
Completely unrelated to metrics, but if this approach of putting metrics
related constants in the SPI works then it could also potentially work for
Accumulo's properties. Could have constants related to those in the SPI maybe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
