keith-turner commented on code in PR #4589:
URL: https://github.com/apache/accumulo/pull/4589#discussion_r1613822956
##########
core/src/main/java/org/apache/accumulo/core/fate/MetaFateStore.java:
##########
@@ -356,9 +358,9 @@ protected FateInstanceType getInstanceType() {
}
@Override
- protected Stream<FateIdStatus> getTransactions() {
+ protected Stream<FateIdStatus> getTransactions(Set<TStatus> statuses) {
Review Comment:
Possibly. Its tricky, many times using streams is fine because of how the
code is called. In this case I don't have a good sense of if the stream is
impacting things significantly. It could impact an operation that wants to
zip through all of the fate ids as quickly as possible. For running fate ops,
suspect list the fate op ids is not the bottleneck. However there is other
code that uses this that is not running fate ops, but is examining them so not
sure about that code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
