dlmarion commented on code in PR #4586:
URL: https://github.com/apache/accumulo/pull/4586#discussion_r1621400065
##########
server/base/src/main/java/org/apache/accumulo/server/compaction/CompactionJobGenerator.java:
##########
@@ -162,23 +166,29 @@ public Map<String,String> getExecutionHints() {
return dispatcher.dispatch(dispatchParams).getService();
}
+ private Level getLevel(TableId tableId, CompactionServiceId serviceId,
Review Comment:
I'm wondering if there is a downside to having too many ConditionalLoggers,
as there is a Caffeine cache for each one. I wonder if it would be better to
have one and add the logger name to the key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
