keith-turner commented on code in PR #4668:
URL: https://github.com/apache/accumulo/pull/4668#discussion_r1638375786
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java:
##########
@@ -670,14 +669,8 @@ private static TabletMetadata
getRootMetadata(ClientContext ctx,
case EVENTUAL:
return getRootMetadata(zkRoot, ctx.getZooCache());
case IMMEDIATE:
- ZooReader zooReader = ctx.getZooReader();
Review Comment:
Looking at how this it used, I think this code could be cleaned up alot.
The eventual read is only for getting the root tablet location. It would
probably be better to just move it to the tablet location cache code and remove
it from ample, simplifying ample. I can do that in a follow on PR, I also see
a problem w/ the cache invalidation that would be cleaner to fix if the code
were consolidated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
