cshannon commented on code in PR #4659: URL: https://github.com/apache/accumulo/pull/4659#discussion_r1639879878
########## test/src/main/java/org/apache/accumulo/test/ample/FlakyInterceptor.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.test.ample; + +import static org.apache.accumulo.core.client.ConditionalWriter.Status.UNKNOWN; +import static org.apache.accumulo.core.util.LazySingletons.RANDOM; + +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; + +import org.apache.accumulo.core.client.ConditionalWriter; +import org.apache.accumulo.core.data.ConditionalMutation; +import org.apache.accumulo.test.ample.metadata.ConditionalWriterInterceptor; +import org.apache.hadoop.io.Text; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class FlakyInterceptor implements ConditionalWriterInterceptor { Review Comment: Yeah, the flaky test is nice to introduce randomness like a real system but it definitely makes it hard to know what broke and how to reproduce it. So anything that can be added to help track down the steps that caused the error would be helpful. There is one more issue with this that I just realized and that is the CI build is generally configured to re-run tests up to 5 times so handle flaky tests. So because of that, if we do get a test failure that is a rare edge case, it is unlikely Jenkins would catch it because it would just re-run and it would pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
