dlmarion commented on code in PR #3746: URL: https://github.com/apache/accumulo/pull/3746#discussion_r1640335430
########## core/src/main/java/org/apache/accumulo/core/clientImpl/AccumuloAccessUtils.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.clientImpl; + +import static java.nio.charset.StandardCharsets.UTF_8; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.accumulo.core.security.Authorizations; + +public class AccumuloAccessUtils { + public static org.apache.accumulo.access.Authorizations convert(Authorizations auths) { + List<String> authStrings = new ArrayList<>(auths.size()); + for (byte[] authBytes : auths.getAuthorizations()) { + authStrings.add(new String(authBytes, UTF_8)); + } + + return org.apache.accumulo.access.Authorizations.of(authStrings); Review Comment: In all places where I have seen this used, it's in the form of: ``` AccessEvaluator.of(AccumuloAccessUtils.convert(Authorizations)) ``` I'm curious if this would be better suited as a non-static method on `org.apache.accumulo.core.security.Authorizations`. Something like `toAccessAuthorizations`. At the very least it would make suggestions work in the IDE. Specifically, I'm thinking of: ``` AccessEvaluator.of(Authorizations.toAccessAuthorizations()) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
