dlmarion commented on code in PR #4681:
URL: https://github.com/apache/accumulo/pull/4681#discussion_r1644326842
##########
server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CompactionCoordinator.java:
##########
@@ -150,6 +154,9 @@ protected CompactionCoordinator(ServerOpts opts, String[]
args, AccumuloConfigur
printStartupMsg();
startCompactionCleaner(schedExecutor);
startRunningCleaner(schedExecutor);
+ // TODO use refresh mechanism to avoid RPCs blocking on getting this count
when it expires
Review Comment:
Does this TODO need to be done before the merge?
##########
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java:
##########
@@ -658,9 +659,8 @@ protected Supplier<UUID> getNextId() {
return UUID::randomUUID;
}
- protected long getWaitTimeBetweenCompactionChecks() {
+ protected long getWaitTimeBetweenCompactionChecks(int numCompactors) {
// get the total number of compactors assigned to this queue
- int numCompactors = ExternalCompactionUtil.countCompactors(queueName,
getContext());
Review Comment:
This is a good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
