keith-turner commented on code in PR #4717:
URL: https://github.com/apache/accumulo/pull/4717#discussion_r1662911362
##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeCoordinator.java:
##########
@@ -309,19 +305,19 @@ public UpgradeStatus getStatus() {
justification = "Want to immediately stop all manager threads on upgrade
error")
private void abortIfFateTransactions(ServerContext context) {
try {
- final ReadOnlyFateStore<UpgradeCoordinator> mfs = new MetaFateStore<>(
- context.getZooKeeperRoot() + Constants.ZFATE,
context.getZooReaderWriter());
- final ReadOnlyFateStore<UpgradeCoordinator> ufs = new
UserFateStore<>(context);
- try (var mfsList = mfs.list(); var ufsList = ufs.list();
- var idStream = Stream.concat(mfsList, ufsList)) {
- if (idStream.findFirst().isPresent()) {
- throw new AccumuloException("Aborting upgrade because there are"
- + " outstanding FATE transactions from a previous Accumulo
version."
- + " You can start the tservers and then use the shell to delete
completed "
- + " transactions. If there are incomplete transactions, you will
need to roll"
- + " back and fix those issues. Please see the following page for
more information: "
- + "
https://accumulo.apache.org/docs/2.x/troubleshooting/advanced#upgrade-issues";);
- }
+ // The current version of the code creates the new accumulo.fate table
on upgrade, so no
+ // attempt is made to read it here. Attempting to read it this point
would likely cause a hang
+ // as not tablets are assigned when this is called. The Fate code is not
used to read from
+ // zookeeper below because the serialization format changed in
zookeeper, that is why a direct
+ // read is performed.
+ if (!context.getZooReader().getChildren(context.getZooKeeperRoot() +
Constants.ZFATE)
Review Comment:
Opened #4721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
