keith-turner commented on PR #4726: URL: https://github.com/apache/accumulo/pull/4726#issuecomment-2210997041
> For now it makes sense to keep both the sync and async methods for getting a job as the current code still uses that until https://github.com/apache/accumulo/pull/4715 is done, but I was wondering if you were planning to drop the sync entry point to get a job eventually? Yeah, it we can drop it once it becomes unused. Could possibly drop it in #4715, but do not have to. I realized there is a problem with the new code for the case where nothing is ever added to the priority queue, get async is called repeatedly, and the futures are canceled. In this case the canceled futures will build up in memory. I think this easy to handle though, will open up a follow on PR to handle that case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
