keith-turner commented on code in PR #71:
URL: https://github.com/apache/accumulo-access/pull/71#discussion_r1668956730
##########
src/main/java/org/apache/accumulo/access/AccessEvaluator.java:
##########
@@ -149,7 +153,32 @@ static AccessEvaluator of(Authorizer authorizer) {
*
*/
static AccessEvaluator of(Collection<Authorizations> authorizationSets) {
- return new
AccessEvaluatorImpl(AccessEvaluatorImpl.convert(authorizationSets));
+ List<AccessEvaluatorImpl> evaluators = new
ArrayList<>(authorizationSets.size());
+ for (Authorizations authorizations : authorizationSets) {
+ evaluators.add(new AccessEvaluatorImpl(authorizations));
+ }
+
+ return new AccessEvaluator() {
Review Comment:
> If this returns an implementation of AccessEvaluator, do we still need
AccessEvaluatorImpl? If so, do we end up having two different implementations?
Yeah there are two impls of the interface now. Still having
AccessEvaluatorImpl makes it really easy for the multiple auths impl to use the
single auths impl, so thinking it simplifies the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
