meatballspaghetti commented on PR #4745: URL: https://github.com/apache/accumulo/pull/4745#issuecomment-2242873893
> @meatballspaghetti - I think you should rebase these changes onto `main`. Reason being that `ArrayByteSequence.reset` will be added in 3.1 (#4735) and overlaps the functionality of `setArray` and `setLength`. I think when you rebase onto `main`, your additions may not be needed at all. I think MutableByteSequence can probably be deleted and the other classes fixed to use the existing ArrayByteSequence methods. I don't think that the `isMutable` member variable needs to be added as it gives a false sense of immutability. Some of the constructors in ArrayByteSequence retain a reference to the underlying byte[] instead of copying it. If that underlying byte[] changes, then the contents of this ArrayByteSequence change. Okay, makes sense. I'll switch to `main` and move forward with just the deletion of `MutableByteSequence`, without the additions from this branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
