keith-turner opened a new pull request, #4748: URL: https://github.com/apache/accumulo/pull/4748
This is a WIP to add an immutable implementation of ByteSequence. With this new class there will two implementations of ByteSequence in the Accumulo API, one being mutable and other immutable. The ByteSequence abstract class easily supports an immutable implementation with its current public methods and requires no changes to its public methods. This commit is a WIP because it lacks unit test, posting the concept for review before implementing unit test. Would need to implement the unit test before taking out of draft. There are TODOs about optimizing also, those could be done in a follow on PR if this is committed. There is a single example of where this new class is used in VisibilityFilter where an iterator caches some data that it does not expect to change for the lifetime of the class. Using the new immutable byte sequence this expectation can be enforced. In a follow on PR could analyze the codebase for other places where this new class could be used. This PR was created based on discussions on #4745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
