dlmarion commented on PR #4715: URL: https://github.com/apache/accumulo/pull/4715#issuecomment-2245358935
> So to clarify, follow on work are of course foundational things and need to be done before anything could be released. IMO, I think the foundation work should be done before this is merged, not released. The implementation of the foundation work may change the approach taken in this PR. > It's not that they are not important, it's that this PR is already 100 files changed and enormous and I don't think we should try and jam everything into one PR or you end up trying to review too much. > > @keith-turner and I talked about creating another branch like no-chop merge but we didn't really think it would be a huge deal to just merge things into elasticity as long as the build works. However it would certainly be possible to just create another branch like we did with no-chop merge and have multiple PRs against that first before merging into back into elasticity. I have no issue with a long-lived feature branch, much like elasticity, for the grpc work. I don't these changes should be merged into elasticity at this time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
