kevinrr888 commented on code in PR #4524:
URL: https://github.com/apache/accumulo/pull/4524#discussion_r1688549092
##########
core/src/main/java/org/apache/accumulo/core/fate/AbstractFateStore.java:
##########
@@ -168,18 +173,16 @@ public void runnable(AtomicBoolean keepWaiting,
Consumer<FateId> idConsumer) {
var transactions = Stream.concat(inProgress, other);
transactions.filter(fateIdStatus ->
isRunnable(fateIdStatus.getStatus()))
.map(FateIdStatus::getFateId).filter(fateId -> {
- synchronized (AbstractFateStore.this) {
- var deferredTime = deferred.get(fateId);
- if (deferredTime != null) {
- if (deferredTime.elapsed().isNegative()) {
- // negative elapsed time indicates the deferral time is in
the future
- return false;
- } else {
- deferred.remove(fateId);
- }
+ var deferredTime = deferred.get(fateId);
+ if (deferredTime != null) {
+ if (deferredTime.elapsed().isNegative()) {
+ // negative elapsed time indicates the deferral time is in
the future
+ return false;
+ } else {
+ deferred.remove(fateId);
}
- return !reserved.contains(fateId);
}
+ return !isReserved(fateId);
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
