kevinrr888 commented on code in PR #4524:
URL: https://github.com/apache/accumulo/pull/4524#discussion_r1690323502
##########
core/src/main/java/org/apache/accumulo/core/fate/AbstractFateStore.java:
##########
@@ -298,7 +299,13 @@ private Optional<FateId> create(FateKey fateKey) {
@Override
public Optional<FateTxStore<T>> createAndReserve(FateKey fateKey) {
- FateId fateId = fateIdGenerator.fromTypeAndKey(getInstanceType(), fateKey);
+ // TODO 4131 not confident about this new implementation of
createAndReserve.
Review Comment:
As it is now, UFS.createAndReserve is pretty lengthy and both
implementations could probably share common code. Was mostly interested if the
impls are good. Can do code cleanup after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
