meatballspaghetti commented on code in PR #4745:
URL: https://github.com/apache/accumulo/pull/4745#discussion_r1693460462
##########
core/src/main/java/org/apache/accumulo/core/data/ArrayByteSequence.java:
##########
@@ -168,10 +161,7 @@ public void reset(byte[] data, int offset, int length) {
@Override
public ByteSequence subSequence(int start, int end) {
- if (start > end || start < 0 || end > length) {
- throw new IllegalArgumentException("Bad start and/end start = " + start
+ " end=" + end
- + " offset=" + offset + " length=" + length);
- }
Review Comment:
Is `length` correct here, or should it changed to `data.length`? Wasn't
completely sure. (Should have selected the updated code block for this comment,
but the same use of `length` is in the new code too.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
