keith-turner commented on code in PR #4767:
URL: https://github.com/apache/accumulo/pull/4767#discussion_r1693576147
##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/queue/CompactionJobPriorityQueue.java:
##########
@@ -107,7 +108,7 @@ public boolean equals(Object o) {
// efficiently removing entries from anywhere in the queue. Efficient
removal is needed for the
// case where tablets decided to issues different compaction jobs than what
is currently queued.
private final TreeMap<CjpqKey,CompactionJobQueues.MetaJob> jobQueue;
- private final int maxSize;
+ private Supplier<Integer> maxSize;
Review Comment:
The way this is used seems like it could be an AtomicInteger (or maybe
integer if only accessed in sync method) instead of supplier. The supplier
passed to constructor seems to contain a fixed value or final constant and the
set method replaces the supplier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
