ddanielr commented on code in PR #4763:
URL: https://github.com/apache/accumulo/pull/4763#discussion_r1693679111
##########
assemble/bin/accumulo-service:
##########
@@ -159,10 +210,13 @@ function main() {
start_service "${@:3}"
;;
stop)
- stop_service
+ stop_service "${@:3:1}"
;;
kill)
- kill_service
+ kill_service "${@:3:1}"
Review Comment:
I agree that shift is better so I can look at modifying this code to avoid
this.
I need to go back and revisit the logic but iirc I was using the substring
Expansion to pull the service name and ignore any additional details only on
stop and kill commands.
This was because we need the additional compaction queue or scan server
group information to be passed on startup so that `accumulo-env.sh` could
support assigning different JAVA_OPTS based on the scan server group or
compaction queue vs just a single server type.
However `stop_service` and `kill_service` don't use those extra args for
anything and instead attempt to treat them as additional service names which
generate a lot of extra log message noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
