cshannon opened a new pull request, #4771: URL: https://github.com/apache/accumulo/pull/4771
This commit updates the fate metrics that are published to include the user fate transactions and not just Meta (zookeeper). The metric names are the same and a tag is now added to the metrics to indicate the fate instance type of either user or meta. This closes #4534 I ended up refactoring the metrics classes to share common code in an abstract class between both types. There's a couple extra metrics for ZK only so I wanted to separate that out. I didn't add any new metrics for the User metrics that might be different than from Meta but we could always add some in the future. I noticed the MetricsIT already scans all the metrics to make sure they are published and I added one new test there to check that the instance type tag was being set properly. Actually testing the values of the metrics would be difficult since both Fate and the metrics updates are a bit non-deterministic as they run async on timers. There wasn't any previous tests for fate metrics so this at least adds something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
