dlmarion commented on code in PR #4781:
URL: https://github.com/apache/accumulo/pull/4781#discussion_r1700030525
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -1048,9 +1051,19 @@ private void
replaceVolumes(List<VolumeUtil.VolumeReplacements> volumeReplacemen
vr.filesToRemove.forEach(tabletMutator::deleteFile);
vr.filesToAdd.forEach(tabletMutator::putFile);
- tabletMutator.submit(
- tm -> tm.getLogs().containsAll(vr.logsToAdd) &&
tm.getFiles().containsAll(vr.filesToAdd
-
.keySet().stream().map(ReferencedTabletFile::insert).collect(Collectors.toSet())));
+ tabletMutator.submit(tm -> {
+ // Check to see if the logs and files and removed. Checking if the
new files or logs were
Review Comment:
```suggestion
// Check to see if the logs and files are removed. Checking if the
new files or logs were
```
##########
test/src/main/java/org/apache/accumulo/test/ample/FlakyAmpleServerContext.java:
##########
@@ -33,13 +36,22 @@
*/
public class FlakyAmpleServerContext extends ServerContext {
+ private final Supplier<Ample> ampleSupplier;
+
public FlakyAmpleServerContext(SiteConfiguration siteConfig) {
super(siteConfig);
+ // Each instance of TestAmple created will create a new Haddop
configuration object. These
Review Comment:
```suggestion
// Each instance of TestAmple created will create a new Hadoop
configuration object. These
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
