keith-turner commented on code in PR #4779:
URL: https://github.com/apache/accumulo/pull/4779#discussion_r1700410434


##########
core/src/main/java/org/apache/accumulo/core/data/Key.java:
##########
@@ -657,6 +657,20 @@ public ByteSequence getRowData() {
     return new ArrayByteSequence(row);
   }
 
+  /**
+   * Writes the row ID into the given <code>ArrayByteSequence</code>. This 
method gives users

Review Comment:
   By covering the following topics in some way, the javadoc could be a bit 
less ambiguous about the goals of this method. 
   
    * Avoids copying row data
    * Avoids allocating objects
    * Calls `{@link 
org.apache.accumulo.core.data.ArrayByteSequence#reset(byte[], int, int)}` which 
only copies references to data.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to