kevinrr888 commented on code in PR #4524:
URL: https://github.com/apache/accumulo/pull/4524#discussion_r1700586932
##########
core/src/main/java/org/apache/accumulo/core/fate/user/FateStatusFilter.java:
##########
@@ -54,8 +55,15 @@ public void init(SortedKeyValueIterator<Key,Value> source,
Map<String,String> op
@Override
public boolean accept(Key k, Value v) {
- var tstatus = ReadOnlyFateStore.TStatus.valueOf(v.toString());
- return valuesToAccept.contains(tstatus);
+ // We may see TStatus values or FateReservation values with how this
filter is used,
+ // only accept TStatus values, return false on FateReservation values,
error otherwise
+ try {
+ var tstatus = ReadOnlyFateStore.TStatus.valueOf(v.toString());
+ return valuesToAccept.contains(tstatus);
+ } catch (IllegalArgumentException e) {
Review Comment:
Reworked iterator. Thanks for the info, this is much nicer than what I had
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
