keith-turner commented on code in PR #4784: URL: https://github.com/apache/accumulo/pull/4784#discussion_r1702072759
########## core/src/main/java/org/apache/accumulo/core/util/Timer.java: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.util; + +import java.time.Duration; +import java.util.concurrent.TimeUnit; + +/** + * This class provides a timer for measuring elapsed time. + */ +public final class Timer { + + private long startNanos; + + private Timer() { + this.startNanos = System.nanoTime(); + } + + /** + * Creates and starts a new Timer instance. + * + * @return a new Timer instance that is already started. + */ + public static Timer startNew() { Review Comment: Could rename this to `start()` since the other `start()` method was deleted. ########## core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReaderIterator.java: ########## @@ -857,11 +857,10 @@ static void doLookup(ClientContext context, String server, Map<KeyExtent,List<Ra MultiScanResult scanResult = imsr.result; if (timer != null) { - timer.stop(); log.trace("tid={} Got 1st multi scan results, #results={} {} in {}", Thread.currentThread().getId(), scanResult.results.size(), (scanResult.more ? "scanID=" + imsr.scanID : ""), - String.format("%.3f secs", timer.scale(SECONDS))); + String.format("%.3f secs", timer.elapsed().toMillis() / 1000.0)); Review Comment: A lot of these immediately call toMillis(). Those could call the method with the time unti ```suggestion String.format("%.3f secs", timer.elapsed(TimeUnit.MILLIS) / 1000.0)); ``` ########## core/src/main/java/org/apache/accumulo/core/util/Timer.java: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.util; + +import java.time.Duration; +import java.util.concurrent.TimeUnit; + +/** + * This class provides a timer for measuring elapsed time. + */ +public final class Timer { + + private long startNanos; + + private Timer() { + this.startNanos = System.nanoTime(); + } + + /** + * Creates and starts a new Timer instance. + * + * @return a new Timer instance that is already started. + */ + public static Timer startNew() { + return new Timer(); + } + + /** + * Resets the start point for this timer. + */ + public void restart() { + this.startNanos = System.nanoTime(); + } + + private long getElapsedNanos() { + return System.nanoTime() - startNanos; + } + + /** + * Checks if the specified duration has elapsed since the timer was started. + * + * @param duration the duration to check. + * @return true if the specified duration has elapsed, false otherwise. + */ + public boolean hasElapsed(Duration duration) { + return getElapsedNanos() >= duration.toNanos(); Review Comment: The Duration object can hold durations that are larger than can fit in a 64 bit integer for nanos. Looked at the javadoc and if that happens then `toNanos()` will throw an exception which is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
