kevinrr888 commented on code in PR #4524:
URL: https://github.com/apache/accumulo/pull/4524#discussion_r1702292110
##########
server/manager/src/main/java/org/apache/accumulo/manager/metrics/fate/meta/MetaFateMetrics.java:
##########
@@ -59,7 +60,8 @@ public void registerMetrics(MeterRegistry registry) {
@Override
protected ReadOnlyFateStore<FateMetrics<MetaFateMetricValues>>
buildStore(ServerContext context) {
try {
- return new MetaFateStore<>(getFateRootPath(context),
context.getZooReaderWriter());
+ return new MetaFateStore<>(getFateRootPath(context),
context.getZooReaderWriter(),
+ AbstractFateStore.createDummyLockID(), null);
Review Comment:
Yeah, can leave this unresolved for making a follow on issue. I put the
dummy lock in many places where a store was created, without regard to whether
reservations would actually occur. A follow on issue can address this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
