dlmarion commented on PR #4787: URL: https://github.com/apache/accumulo/pull/4787#issuecomment-2269884659
> Apologies if any of my comments were confusing/misleading. My only concern is retrying infinitely, not about the logic for retrying. It may be perfectly okay to retry infinitely, I'm just not sure and was throwing that out for discussion All good, I'm just trying to make sure things are handled consistently. Based on the old ZooStore implementation, which is now the MetaFateStore class, I think we should retry indefinitely in the UserFateStore. Reason being that the code that calls `Fate.startTransaction()` doesn't currently expect or handle an exception that would cause them to retry. The code that calls `Fate.startTransaction` expects success. If we want to limit the number of retries, then we should throw a `RetriesExceededException` or similar and modify the calling code to either retry or supply appropriate messaging to the user that their call to `TableOperations.compact` or similar has failed to start. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
