ctubbsii commented on code in PR #4785:
URL: https://github.com/apache/accumulo/pull/4785#discussion_r1708177809
##########
core/src/main/java/org/apache/accumulo/core/fate/ZooStore.java:
##########
@@ -164,8 +164,10 @@ public long reserve() {
}
if (deferred.containsKey(tid)) {
- if (deferred.get(tid).elapsed().compareTo(Duration.ZERO) > 0) {
- deferred.remove(tid);
+ long deferredTime = deferred.get(tid);
+ long currentTime = System.nanoTime();
+ if (currentTime >= deferredTime) {
Review Comment:
To me, this seems very confusing. It leads to nonsensical interpretations
like having a negative elapsed time. To me, this indicates the calling code
could be improved with better semantics. If we want a Countdown timer instead
of an Elapsed timer, then we should just create a separate timer that counts
down, with explicit semantics in its its API, rather than try to recreate it
conceptually via low-level manipulations of the internals to get the desired
outcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
