cshannon opened a new pull request, #4797: URL: https://github.com/apache/accumulo/pull/4797
This refactors `ExternalCompaction_2_IT` so that the same tests can be run using a Flaky Ample implementation which will randomly return an UNKNOWN status when submitting conditional mutations. The tests being run are related to cancelling compaction jobs so this test makes sure the rejection handlers related to job cancellation in CompactionCoordinator work correctly, such as the rejection handler used inside of CompactionCoordinator.compactionFailedForLevel This implements one of the methods detected as missing code coverage that is listed in #4710 I first looked at using TestAmple directly but there would have a been a ton of changes to isolate and test as there would have been a lot of refactoring to be able to ceate a CompactionCoordinator in an IT and inject a test Ample instance. It was much simpler to use FlakyAmple for the testing and extend the existing tests. I verified that when running the new test, if the rejection handler is not used and commented out, the tests will fail (at least on some runs as UNKNOWN status is randomly returned) **Note:** that I renamed ExternalCompaction_2_IT to ExternalCompaction2BaseIt and created a new ExternalCompaction2IT class so that git would pick up the rename and not have a huge diff. We could rename it back after this is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
