ddanielr commented on code in PR #4800:
URL: https://github.com/apache/accumulo/pull/4800#discussion_r1714176893
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -440,6 +441,14 @@ private TableMgmtStats
manageTablets(Iterator<TabletManagement> iter,
new CompactionJobGenerator(new
ServiceEnvironmentImpl(manager.getContext()),
tableMgmtParams.getCompactionHints(),
tableMgmtParams.getSteadyTime());
+ try {
+ CheckCompactionConfig.validate(manager.getConfiguration());
+ } catch (SecurityException | IllegalArgumentException |
IllegalStateException
+ | ReflectiveOperationException e) {
+ LOG.error("Error validating compaction configuration, not performing
compactions.", e);
Review Comment:
Pausing compaction seems like the correct action to take since compaction
starvation of a particular table could occur if two different planners are
sending different priority jobs to the same queue.
I feel like this message needs stronger wording
`Error validating compaction configuration, all compactions are paused until
the config is fixed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
