DomGarguilo commented on code in PR #4790:
URL: https://github.com/apache/accumulo/pull/4790#discussion_r1718546995
##########
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java:
##########
@@ -216,7 +217,7 @@ public void collect(GCStatus status) {
} finally {
span5.end();
}
-
+ hasCollected.set(true);
Review Comment:
This is what I was thinking. I think this approach is best because if we set
it only afterwards, there could be a race condition potentially where this
block is entered again before the boolean is set at the end of the first run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
