dlmarion commented on code in PR #4813:
URL: https://github.com/apache/accumulo/pull/4813#discussion_r1723506984
##########
test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompaction2BaseIT.java:
##########
@@ -70,7 +70,7 @@
import org.junit.jupiter.api.Test;
import org.slf4j.LoggerFactory;
-public class ExternalCompaction2BaseIT extends SharedMiniClusterBase {
+public abstract class ExternalCompaction2BaseIT extends SharedMiniClusterBase {
Review Comment:
This IT was being run, likely because the class name ends in `IT`. The two
subclasses are the only ones that should be run.
##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeCoordinator.java:
##########
@@ -263,7 +263,7 @@ private void validateProperties(ServerContext context) {
}
try {
CheckCompactionConfig.validate(context.getConfiguration());
- } catch (SecurityException | IllegalArgumentException |
ReflectiveOperationException e) {
Review Comment:
I changed this to catch RuntimeException because JSON parsing exceptions
were also being thrown from the tests.
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -443,11 +443,12 @@ private TableMgmtStats
manageTablets(Iterator<TabletManagement> iter,
try {
CheckCompactionConfig.validate(manager.getConfiguration());
- } catch (SecurityException | IllegalArgumentException |
IllegalStateException
- | ReflectiveOperationException e) {
+ this.metrics.clearCompactionServiceConfigurationError();
+ } catch (RuntimeException | ReflectiveOperationException e) {
Review Comment:
I changed this to catch RuntimeException because JSON parsing exceptions
were also being thrown from the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
