kevinrr888 commented on code in PR #4816:
URL: https://github.com/apache/accumulo/pull/4816#discussion_r1727128733
##########
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java:
##########
@@ -335,6 +352,52 @@ public boolean isSamplingEnabled() {
public SamplerConfiguration getSamplerConfiguration() {
return RFileScanner.this.getSamplerConfiguration();
}
+
+ @Override
+ public TableId getTableId() {
+ return null;
Review Comment:
Went with the latter, I assumed the way this would probably be used is
`env.getPluginEnv().getConfiguration(env.getTableId())`. If we throw an error
on `env.getTableId()` that might be confusing because not sure what user would
pass to `getConfiguration(TableId)`... User could create their own dummy id but
I feel it makes more sense for us to make it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
