cshannon opened a new issue, #4830: URL: https://github.com/apache/accumulo/issues/4830
I have noticed there are a lot of variables all over the code base that could be marked final (intellij has flagged them). Some reasons to do so: 1. Declares intent that variables should not change which is self documenting 2. Prevent inadvertent errors by reassignment 3. Compiler optimizations and performance 4. Thread safety Not all code needs hanging or fixing, obviously would not want to change things like generated Thrift code or test code. Also in some cases it could be a false positive (like anything set by reflection like jcommander args we would not want to mark final) but in many cases the variables could be marked final. For now I plan to exclude shell and monitor as well (not sure if we would break things like Jersey). Because of the merge conflicts that would be generated, it would best to do this separately in each branch and just merge forward as an empty commit using -S ours. We can start with elasticity and always go back and fix 2.1 and 3.1 if desired and merge forward the empty commit. Modules to address, some are small and can be grouped together one PR probably. - [ ] accumulo-server-base - [ ] compactor - [ ] core - [ ] hadoop-mapreduce - [ ] gc - [ ] manager - [ ] tserver -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
