dlmarion commented on code in PR #4840:
URL: https://github.com/apache/accumulo/pull/4840#discussion_r1731780175
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java:
##########
@@ -408,6 +408,7 @@ public void run() {
metricsInfo.addCommonTags(List.of(Tag.of("resource.group", groupName)));
scanMetrics = new TabletServerScanMetrics();
+ sessionManager.setZombieCountConsumer(scanMetrics::setZombieScanThreads);
Review Comment:
I'm confused by this line. `TabletServerScanMetrics.setZombieScanThreads`
returns `void`.
##########
core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java:
##########
@@ -674,7 +674,7 @@ public interface MetricsProducer {
String METRICS_SCAN_QUERY_SCAN_RESULTS = METRICS_SCAN_PREFIX +
"query.results";
String METRICS_SCAN_QUERY_SCAN_RESULTS_BYTES = METRICS_SCAN_PREFIX +
"query.results.bytes";
String METRICS_SCAN_SCANNED_ENTRIES = METRICS_SCAN_PREFIX +
"query.scanned.entries";
-
+ String METRICS_SCAN_ZOMBIE_THREADS = METRICS_SCAN_PREFIX + "zombie.threads";
Review Comment:
We've been trying to keep the class javadoc in sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
